Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from dep to vgo #4754

Closed
wants to merge 2 commits into from
Closed

Change from dep to vgo #4754

wants to merge 2 commits into from

Conversation

bep
Copy link
Member

@bep bep commented May 22, 2018 •
edited

This was surprisingly painless. There is still a lot of scripts etc. that needs to be updated, so this is work in progress. But once this is done we can much easier make the Blackfriday v2 transition.

bep added 2 commits May 22, 2018 17:40
@bep
Run vgo build
060ba63
@bep
Adjust go.mod
1464912 
Running `vgo build` ran almost without hickups out of the box, but two manual adjustments had to be applied:

1. github.com/kyokomi/emoji: uses a semver tag format not supported by vgo it seems. Manually adjusted to latest commit.
2. smartcrop: We use an unreleased version, vgo picked the latest release Manually adjusted to the latest commit.
@bep bep added the InProgress label May 22, 2018
@rsc
Copy link

rsc commented May 22, 2018

Filed kyokomi/emoji#23

@akavel
Copy link

akavel commented May 24, 2018 •
edited

Curious question: was it done "from scratch", or by having vgo auto-import versions from the Gopkg.* files?

edit: from a quick browse through the files, e.g. github.com/disintegration/imaging is at v1.4.2 in go.mod, but at v1.2.4 in Gopkg.lock; does it mean vgo ignores Gopkg.lock, or some deeper dependency bumped the version?

@bep
Copy link
Member Author

bep commented May 24, 2018

@akavel this was done with vgo build with some small manual adjustments. I don't think vgo reads Gopkg.lock -- but I don't care too much. This is work in progress, and will be tested/checked before going live. But this discussion belongs somewhere else.

@rsc
Copy link

rsc commented May 24, 2018

Just to set the record straight because this is a popular page right now, dep does read Gopkg.lock. If you are happily using dep with a Gopkg.lock you like, then running a vgo command should write an equivalent go.mod file for you. But @bep is right that further discussion about that fact belongs elsewhere.

@philoserf
Copy link
Contributor

philoserf commented May 24, 2018 •
edited

Perhaps a checklist of required changes are in order. e.g.

  • Update Dockerfile
  • Update magefile.go
  • Remove Gopkg.* files
  • Update README.md
    ...

@bep bep mentioned this pull request May 27, 2018
Closed
@kaushalmodi kaushalmodi mentioned this pull request Jul 20, 2018
Closed
@bep bep added this to the v0.48 milestone Aug 25, 2018
@bep bep mentioned this pull request Aug 25, 2018
Closed
5 tasks
@bep
Copy link
Member Author

bep commented Aug 25, 2018

I have started a new PR.

@bep bep closed this Aug 25, 2018
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
InProgress
Projects
None yet
Milestone
v0.48
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bep @rsc @akavel @philoserf